Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update code owners #187

Merged
merged 5 commits into from
Apr 1, 2024
Merged

docs: update code owners #187

merged 5 commits into from
Apr 1, 2024

Conversation

mkbreuningIOHK
Copy link
Contributor

@mkbreuningIOHK mkbreuningIOHK commented Mar 15, 2024

Description:

  • Code owners: the content editor will be automatically added to any PR related to markdown files
  • Code owners: update by adding Todor Kolev (still not a member it seems though)
  • Pull request template: add the link to the contributing guideline
  • Pull request template: modify to be able to check / uncheck boxes without editing the comment

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

# npm audit report

follow-redirects  <=1.15.5
Severity: moderate
follow-redirects' Proxy-Authorization header kept across hosts - https://github.com/advisories/GHSA-cxjh-pqwp-8mfp
fix available via `npm audit fix`
node_modules/follow-redirects

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

@mkbreuningIOHK mkbreuningIOHK marked this pull request as ready for review March 15, 2024 11:10
Copy link

# npm audit report

follow-redirects  <=1.15.5
Severity: moderate
follow-redirects' Proxy-Authorization header kept across hosts - https://github.com/advisories/GHSA-cxjh-pqwp-8mfp
fix available via `npm audit fix`
node_modules/follow-redirects

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

At the request of the implementation team, this will provide a way to check/uncheck boxes without editing.

Signed-off-by: mkbreuning <[email protected]>
@mkbreuningIOHK
Copy link
Contributor Author

@elribonazo , can you review this PR: this will fix the PR template checkbox as well :)

Copy link

github-actions bot commented Mar 27, 2024

Lines Statements Branches Functions
Coverage: 69%
70.06% (1823/2602) 56.59% (717/1267) 72.65% (542/746)

JUnit

Tests Skipped Failures Errors Time
408 2 💤 0 ❌ 0 🔥 1m 0s ⏱️

@elribonazo elribonazo self-requested a review March 28, 2024 16:29
@mkbreuningIOHK mkbreuningIOHK merged commit 11cc07c into master Apr 1, 2024
5 checks passed
@mkbreuningIOHK mkbreuningIOHK deleted the sdk-ts-codeowners branch April 1, 2024 03:00
elribonazo pushed a commit that referenced this pull request Apr 25, 2024
elribonazo pushed a commit that referenced this pull request May 2, 2024
elribonazo added a commit that referenced this pull request May 2, 2024
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
elribonazo pushed a commit that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants