Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mercury): Add return route with value all to async messages that are initiated by the holder. #85

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Aug 30, 2023

Description

Fixes return_route field not being send to the prismMediator on specific protocols that are async and initiated by the holder.

Jira link

link

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

curtis-h and others added 3 commits August 22, 2023 16:50
* master:
  chore(release): release 2.3.0 # [2.3.0](v2.2.0...v2.3.0) (2023-08-28)
  feat(Mercury): adding return_route: all to didcomm Message (#80)
  fix(docs): Add static reference to the docs. (#82)
  chore(release): release 2.2.0 # [2.2.0](v2.1.0...v2.2.0) (2023-08-23)
  test: update github pipelines (#77)
…upRequest and Pickup received DIDCOMM v2 protocols
@elribonazo elribonazo changed the title Feature/atl 5629 fix(mercury): Add return route with value all to async messages that are initiated by the holder. Aug 30, 2023
* master:
  feat(Sec): updating package dependencies (#83)
  feat(Apollo): MnemonicWordList must be 24 or 12 words long (#81)
@github-actions
Copy link

Lines Statements Branches Functions
Coverage: 35%
34.87% (1369/3925) 22.67% (560/2470) 35.41% (409/1155)

JUnit

Tests Skipped Failures Errors Time
144 1 💤 0 ❌ 0 🔥 40.371s ⏱️

@elribonazo
Copy link
Contributor Author

Tested through the Browser + Nodejs demos

@elribonazo elribonazo merged commit 5e56675 into master Aug 30, 2023
@elribonazo elribonazo deleted the feature/ATL-5629 branch August 30, 2023 13:44
atala-dev added a commit that referenced this pull request Aug 30, 2023
# [2.4.0](v2.3.0...v2.4.0) (2023-08-30)

### Bug Fixes

* **mercury:** Add return route with value all to async messages that are initiated by the holder. ([#85](#85)) ([5e56675](5e56675))

### Features

* **Apollo:** MnemonicWordList must be 24 or 12 words long ([#81](#81)) ([fbe5678](fbe5678))
* **Sec:** updating package dependencies ([#83](#83)) ([460e123](460e123))
github-actions bot pushed a commit that referenced this pull request Aug 30, 2023
# [2.4.0](v2.3.0...v2.4.0) (2023-08-30)

### Bug Fixes

* **mercury:** Add return route with value all to async messages that are initiated by the holder. ([#85](#85)) ([5e56675](5e56675))

### Features

* **Apollo:** MnemonicWordList must be 24 or 12 words long ([#81](#81)) ([fbe5678](fbe5678))
* **Sec:** updating package dependencies ([#83](#83)) ([460e123](460e123))
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
…are initiated by the holder. (hyperledger-identus#85)

Co-authored-by: Curtish <[email protected]>
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
# [2.4.0](hyperledger-identus/sdk-ts@v2.3.0...v2.4.0) (2023-08-30)

### Bug Fixes

* **mercury:** Add return route with value all to async messages that are initiated by the holder. ([hyperledger-identus#85](hyperledger-identus#85)) ([5e56675](hyperledger-identus@5e56675))

### Features

* **Apollo:** MnemonicWordList must be 24 or 12 words long ([hyperledger-identus#81](hyperledger-identus#81)) ([fbe5678](hyperledger-identus@fbe5678))
* **Sec:** updating package dependencies ([hyperledger-identus#83](hyperledger-identus#83)) ([460e123](hyperledger-identus@460e123))

Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants