Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apollo): integrate with apollo kmm #107

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Dec 12, 2023

Overview

Integrates with Apollo KMM as the main cryptographic source and deletes all cryptography logic done in swift SDK internally.

Fixes ATL-5690

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to the above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to the above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to the above: I have added tests to cover my changes
  • If yes to the above: I have taken care to cover edge cases in my tests

Copy link

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there is an issue downloading ApolloBinary

downloaded archive of binary target 'ApolloBinary' does not contain expected binary artifact named 'ApolloBinary'
Resolved source packages:
  atala-prism-wallet-sdk-swift: (null)

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-5690 branch 2 times, most recently from dcb6069 to 2247cea Compare December 12, 2023 18:01
@goncalo-frade-iohk
Copy link
Contributor Author

@cristianIOHK yeah was checking that, it seems I had to upgrade the VM to macOS-13 and Xcode to 15 so it works again

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-5690 branch 2 times, most recently from 0593bd4 to 6aa560d Compare December 12, 2023 23:48
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-5690 branch 2 times, most recently from 610474f to 68e942e Compare December 22, 2023 11:44
BREAKING CHANGE: Updated Apollo public interface to be more in line with Cryptographic abstraction
@goncalo-frade-iohk goncalo-frade-iohk merged commit 32bdfbd into main Dec 22, 2023
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/ATL-5690 branch December 22, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants