Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

chore: Don't send service priority if not set #297

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Nov 4, 2022

Sidetree VDR: Don't send service priority if not set

Closes #296

Signed-off-by: Sandra Vrtikapa [email protected]

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #297 (d77d3f9) into main (1ef20ed) will decrease coverage by 2.91%.
The diff coverage is 100.00%.

❗ Current head d77d3f9 differs from pull request most recent head e2e5a7b. Consider uploading reports for the commit e2e5a7b to get more accurate results

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   85.18%   82.26%   -2.92%     
==========================================
  Files          25        2      -23     
  Lines        4003      344    -3659     
==========================================
- Hits         3410      283    -3127     
+ Misses        354       31     -323     
+ Partials      239       30     -209     
Impacted Files Coverage Δ
component/vdr/sidetree/client.go 81.62% <100.00%> (ø)
.../vdr/trustbloc/config/memorycacheconfig/service.go
component/storage/couchdb/store.go
...omponent/vdr/trustbloc/didconfiguration/helpers.go
...vdr/trustbloc/discovery/staticdiscovery/service.go
component/vdr/trustbloc/models/stakeholder.go
component/vdr/orb/internal/ldcontext/ldcontext.go
component/vdr/orb/vdr.go
...nt/vdr/trustbloc/config/signatureconfig/service.go
...omponent/vdr/trustbloc/didconfiguration/service.go
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sidetree VDR: Don't send service priority if not set

Closes hyperledger-aries#296

Signed-off-by: Sandra Vrtikapa <[email protected]>
@fqutishat fqutishat merged commit 07bfbe4 into hyperledger-aries:main Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't send service priority if not set
3 participants