This repository was archived by the owner on Mar 27, 2024. It is now read-only.
chore: Don't add empty anchor origin to sidetree requests #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently sidetree client adds anchorOrigin even when it is empty. Only add anchor origin to create/recover requests if anchor origin is not empty. Closes hyperledger-aries#294 Signed-off-by: Sandra Vrtikapa <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 85.27% 82.26% -3.01%
==========================================
Files 25 2 -23
Lines 4000 344 -3656
==========================================
- Hits 3411 283 -3128
+ Misses 352 31 -321
+ Partials 237 30 -207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
troyronda
approved these changes
Nov 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sidetree client adds anchorOrigin even when it is empty. Only add anchor origin to create/recover requests if anchor origin is not empty.
Closes #294
Signed-off-by: Sandra Vrtikapa [email protected]