This repository was archived by the owner on Sep 22, 2023. It is now read-only.
Use event bus to send notifications to Admin connections #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
…ssages Using event bus rather than re-implementing BasicMessageHandler
Signed-off-by: Daniel Bluhm <[email protected]>
And regression test Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
…date fix: changes from recent acapy and event-bus updates
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Convert RequestPres message and handler to new style. Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Fix errors in issuance after ACA-Py updates
Signed-off-by: Matthew Wright <[email protected]>
…credentials Added message handler to delete credentials from the Holder
Signed-off-by: Matthew Wright <[email protected]>
…ation-delete Added message handler to delete presentations from the Holder
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
Signed-off-by: Matthew Wright <[email protected]>
adding admin-holder/0.1/credential-offer-reject
adding admin-holder/0.1/presentation-request-reject
Changes to support running on the latest ACA-Py
Signed-off-by: Daniel Bluhm <[email protected]>
burdettadam
approved these changes
Jun 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the newly added event bus in ACA-Py to greatly enhance ability to keep admin connections up to date without polling.
Along with these enhancements are improvements to the credentials exchange and presentations exchange features that were not previously possible without an asynchronous notification system. Instead of automatically accepting all credentials and presentation requests, the toolbox plugin now supports sending notifications about newly received credential offers and presentation requests and can wait for input before accepting.