feat: update tunnels in demo to use simplified service #106
Conversation
Signed-off-by: Daniel Bluhm <[email protected]>
|
|
||
| COPY --chown=indy demo/agent-tunnel-wait.sh ./agent-tunnel-wait.sh | ||
| RUN chmod +x agent-tunnel-wait.sh | ||
| ADD --chown=indy https://raw.githubusercontent.com/Indicio-tech/agent-tunnel/02351dd87e105a7522a2d752ddd174a52a6755a1/wait-curl.sh ./wait.sh |
There was a problem hiding this comment.
Is there a specific reason for this to be pointing at a specific commit, if the purpose of this PR is to make things easier to follow upstream's changes?
There was a problem hiding this comment.
Fair question. By pointing to a specific commit, we make pulling updates from upstream intentional but still trivial. If we want updated scripts, just grab the new commit. In future, I would like to have this point to a release instead of a commit but this will function essentially the same way.
| ENTRYPOINT ["/bin/bash", "-c", "./agent-tunnel-wait.sh \"$@\"", "--"] | ||
| CMD ["poetry", "run", "aca-py", "start", "--plugin", "acapy_plugin_toolbox", "--arg-file", "configs/default.yml"] | ||
| ENTRYPOINT ["/bin/bash", "-c", "./acapy-endpoint.sh poetry run aca-py \"$@\"", "--"] | ||
| CMD ["start", "--arg-file", "configs/default.yml"] |
There was a problem hiding this comment.
Is the toolbox plugin automatically detected now? I see that the --plugin acapy_plugin_toolbox argument has been removed, and it does not appear to be in the compose files as well.
Based on the fact that the compose files did not have such an argument before, I believe that it is fine to remove the plugin argument. I'm assuming that this is fine.
There was a problem hiding this comment.
The plugin option was already in the config file. It's presence in the command was redundant so I dropped it.
The upstream
agent-tunnelservice has been updated to make things simpler and more reliable. We now pull from the wait script available in that repo and just wrap with setting the ACA-Py environment variable. This should help us to consume improvements from upstream in the future more easily.