-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Tokio 1.0.0 ecosystem #530
Upgrade to Tokio 1.0.0 ecosystem #530
Conversation
Work in progress for updating Tonic to Tokio 1.0. Since tower has not been released to crates.io, a git dependency is taken instead.
515445e
to
329fe32
Compare
It looks like
So I think it would be good to drop the other crates, which still depend on tokio 0.2 as well. |
Oh yes good catch, fixed thx |
|
I've tried updating my codebase to use this patch and ran into something a little annoying. It seems |
@davidpdrsn I'm not sure how that'd be useful for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will get this merged so we can move forward.
hyper = "0.13" | ||
warp = { version = "0.2", default-features = false } | ||
hyper = "0.14" | ||
warp = { git = "https://github.com/aknuds1/warp", branch = "chore/upgrade-tokio", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for examples, so not blocking a release!
@coolreader18 its being fixed in tower as we speak 😊 |
Are there any other changes needed for a new release of tonic? Can't wait to get all the good bits that have been added since 0.3.1! |
@edrevo going through that all right now :) |
Hey 👋 ,
A quick PR to finish the work done by @marshaled here #514.
Before merging, we have to wait for the release of
warp
, this PR depends on a fork.