-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tonic-build: Builder: add {enum,message}_attributes #1234
tonic-build: Builder: add {enum,message}_attributes #1234
Conversation
Signed-off-by: Richard Leitner <[email protected]>
Signed-off-by: Richard Leitner <[email protected]>
Should probably add message attribute as well? tokio-rs/prost@14ac71e#diff-702d1c883416266db565804e8243178a5e3b59e9c22dff7d3161247d13aad208R502 |
ACK. Will update the PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Richard Leitner <[email protected]>
Forgot to run cargo fmt on the message_attributes patch. I've updated the PR. Sorry for missing it on the first try. |
Thank you g0hl1n. |
+1. Would love to use this to add the derive_builder to the message generated code so that I can generate protos without explicitly providing every field (https://crates.io/crates/derive_builder) Is there anything I can do to help get the release out @g0hl1n ? (cc @samiam376) |
It might be a bit to get a release out I believe there are some breaking changes on master and I am traveling over the next few weeks (and was just travelling). So I will need some time to sort that out. Sorry about that. |
Motivation
The latest prost-build introduced enum_attribute and message_attribute configurations. We should support it.
Solution
Update prost-build to v0.11.6 and add the enum_attribute and message_attribute forwarders.