Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headers): Implement Content-Language header field #485

Merged
merged 1 commit into from
Apr 27, 2015
Merged

feat(headers): Implement Content-Language header field #485

merged 1 commit into from
Apr 27, 2015

Conversation

pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Apr 27, 2015

Closes #475

#[doc="# ABNF"]
#[doc="```plain"]
#[doc="Content-Language = 1#language-tag"]
#[doc="```"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a usage example, per #468?

Or, I wonder... would the header! macro be able to generate a usage example automatically? Then we'd suddenly have much better docs...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating it automatically is not possible with macros currently. But it should be basically a copy & paste job: copy the values from the tests to the docs. Or do you want a program example? (We could create samples for classes of headers)

@pyfisch
Copy link
Contributor Author

pyfisch commented Apr 27, 2015

fixed nits

seanmonstar added a commit that referenced this pull request Apr 27, 2015
feat(headers): Implement Content-Language header field
@seanmonstar seanmonstar merged commit bd5e8f1 into hyperium:master Apr 27, 2015
@pyfisch pyfisch deleted the content-language branch April 28, 2015 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Content-Language header
2 participants