Added TLS/SSL support to server #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// An acceptor for HTTP protocol over TCP. | ||
| HttpA(TcpAcceptor), | ||
| /// An acceptor for HTTP protocol over TCP protected by TLS/SSL. | ||
| HttpsA(TcpAcceptor, Arc<SslContext>) |
There was a problem hiding this comment.
SslContext doesn't derive Clone, and using a reference causes a lot of lifetimes to be required, so this is the best solution I can come up for this. Any thoughts?
Closed
|
Thanks, fantastic! I'm not ignoring this, I've been thinking about the design here. I might say that we merge this and refine the design if a better one is thought of... |
|
Thanks! I was thinking using some structs like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should work, but I'm still trying to figure out how to test it. Sorry, I'm new at this contributing-to-open-source-projects thing!