Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job for wheeling #70

Merged
merged 1 commit into from
Nov 1, 2020
Merged

add job for wheeling #70

merged 1 commit into from
Nov 1, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Nov 1, 2020

this should produce the following wheel artifacts:

  • manylinux1:
    • cpython 2.7 (wide + narrow unicode flavors)
    • cpython3.5+ (abi3)
    • pypy2.7
    • pypy3.6
    • pypy3.7
  • manylinux2010
    • pypy2.7
    • pypy3.6
    • pypy3.7
  • macos:
    • cpython2.7
    • cpython3.5+ (abi3)
  • windows:
    • cpython2.7 (x86 + x64)
    • cpython3.5+ (abi3) (x86 + x64)

.github/workflows/wheel.yml Show resolved Hide resolved
.github/workflows/wheel.yml Show resolved Hide resolved
.github/workflows/wheel.yml Show resolved Hide resolved
.github/workflows/wheel.yml Show resolved Hide resolved
@hynek hynek merged commit a861156 into hynek:master Nov 1, 2020
@hynek
Copy link
Owner

hynek commented Nov 1, 2020

Thank you sooo muuuch!

@hynek
Copy link
Owner

hynek commented Nov 1, 2020

So one thing: I think I don't want it to build the wheels from source but do it the same way like before: wheel the sdist for PyPI. Simply because it makes it easier to add wheels to existing releases and disconnects the wheeling CI from the source code version (I wouldn't know how to build 20.1.0 wheels rn).

Would that be a lot of work? Or do you know a quick way of getting argon2_cffi-20.1.0-cp35-abi3-win(32|64).whl?

@asottile
Copy link
Contributor Author

asottile commented Nov 1, 2020

ah yeah with workflow_dispatch it can take a parameter (the version for example)

we wouldn't be able to get the cp35-abi3 wheels for 20.1.0 though because we'd need the setup.py change from #69

@asottile
Copy link
Contributor Author

asottile commented Nov 1, 2020

so in theory this does that: #71 -- I'm going to get some sleep though, will check on this tomorrow!

@hynek
Copy link
Owner

hynek commented Nov 1, 2020

Ah damn, right. Hm, maybe I'll just publish a new version just with packaging fixes but I'd still prefer the #71 approach. I hope we'll find a way to figure it out/test it! 🤞

@stonebig
Copy link

stonebig commented May 9, 2021

could we have a wheel for pypy3.7-v7.3.5rc2-win64 (or better) ?

@hynek
Copy link
Owner

hynek commented May 9, 2021

Looks like GitHub Actions is still on Python 3.6.12[pypy-7.3.3-final] so we're gonna have to wait unfortunately.

@asottile
Copy link
Contributor Author

asottile commented May 9, 2021

might work, didn't test it #86

@stonebig
Copy link

stonebig commented May 9, 2021

there is a problem in windows 64bit wheel codification with pypy3.7-v7.3.4
a fix for this wheel codification is in pypy3.7-v7.3.5rc2
another fix round 'cpyext' is necessary, and there will be a pypy3.7-v7.3.5rc3

@asottile
Copy link
Contributor Author

asottile commented May 9, 2021

I don't think github-actions has release candidates for pypy

@hynek
Copy link
Owner

hynek commented May 18, 2021

Thanks to @asottile we now have 7.3 wheels for Windows and macOS on PyPI. Please test and report! 7.4 will have to wait until GHA adds them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants