Remove notebook dependency #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devincowan
changed the title
|
I made some changes removing notebook entirely, that 🤞 I'm hoping will work... |
devincowan
changed the title
devincowan
commented
Feb 13, 2025
| from tornado.web import StaticFileHandler | ||
| import os | ||
|
|
||
| import jupyter_server | ||
| from jupyter_server.extension.application import ExtensionApp | ||
| from notebook import DEFAULT_STATIC_FILES_PATH, DEFAULT_TEMPLATE_PATH_LIST | ||
| from jupyter_server import DEFAULT_TEMPLATE_PATH_LIST | ||
| from jupyter_server import DEFAULT_STATIC_FILES_PATH |
There was a problem hiding this comment.
When testing locally it looks like there are issues with the static files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading notebook version in hopes it resolves dependency tree for
hydroshare_on_jupyterTrouble going to >6.5.5 but <7.x -- these newer versions seem to have pyzmq pinned <v25 which is not compatible with the other packages in the extension it looks like