Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the file and folder on hover issues #5733

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MSDrao
Copy link
Contributor

@MSDrao MSDrao commented Jan 31, 2025

Pull Request Checklist:

  • Positive Test Case Written by Dev
  • Automated Testing
  • Sufficient User and Developer Documentation
  • Passing Jenkins Build
  • Peer Code review and approval

Positive Test Case

  1. [Enter positive test case here]

@MSDrao MSDrao requested a review from devincowan January 31, 2025 18:05
@MSDrao MSDrao self-assigned this Jan 31, 2025
Copy link

Test Results

    2 files  ±0      2 suites  ±0   1h 29m 42s ⏱️ - 1m 20s
1 415 tests ±0  1 399 ✅ ±0  16 💤 ±0  0 ❌ ±0 
1 527 runs  ±0  1 509 ✅ ±0  18 💤 ±0  0 ❌ ±0 

Results for commit bc7c02a. ± Comparison against base commit e7a6ffa.

@devincowan
Copy link
Contributor

devincowan commented Feb 3, 2025

@MSDrao please link the issues that you are addressing to this PR. I linked #5729 and #5730 but in the future you should do this.

Copy link
Contributor

@devincowan devincowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with a suggestion for improvement

Comment on lines +244 to +246
#div_id_agency_name {
margin-bottom: 8px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but might not be the ideal way.
We already have style rules handling these forms, take a look at:
https://github.com/hydroshare/hydroshare/blob/2.15.11/theme/static/css/hydroshare_core.css#L1026-L1028
Instead of adding one-off css rules in funding-agency.html, see if you can find a more general solution that ties in with the existing css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants