Make the CLI more useful #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in hwchen#201, the existing debug print of credentials gives no information about the underlying platform credential. This fixes that.
This adds API to credentials to provide better debugging, and implements that API in the built-in credential stores so it's exposed in the CLI. This is a dot release rather than a full release because the additional API is implemented in a backward-compatible way. Clients *can* extend their implementations to take advantage of it, but they don't have to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #201, the CLI was not allowing empty username value, even if the platform did. In addition, when returning an
Ambiguouserror, the debug formatting of the returned credentials was unrevealing. These are both now fixed.Fixes #201.