Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog not updated with 3.0 #189

Closed
VorpalBlade opened this issue Jul 14, 2024 · 2 comments · Fixed by #191
Closed

Changelog not updated with 3.0 #189

VorpalBlade opened this issue Jul 14, 2024 · 2 comments · Fixed by #191
Assignees

Comments

@VorpalBlade
Copy link

CHANGELOG.md appears to not contain anything after version 2.0.1?

@VorpalBlade
Copy link
Author

VorpalBlade commented Jul 14, 2024

I would especially appreciate if the changelog contained info such as "what happened to the platform-freebsd feature" (which doesn't seem to have a direct replacement).

PS. I also want to say thank you for the option to avoid zbus now. That shaved about 2 MB off my release binary (down to 3.9 MB now).

@brotskydotcom
Copy link
Collaborator

So sorry for missing the changelog update in this release! I'll get on that right away.

All of the platform-* features have gone away in this release. Instead, you control which specific credential stores you want to include by specifying their specific features, and your build will contain all the specified ones that work on your build platform. So, for example, if you specify the dbus-secret-service and apple-native features and you build for OS freebsd, you will get the dbus-secret-service credential store. If you use the same build command on macOS, you will get the Keychain credential store. I will update the README to explain this.

Thanks for the thanks! Having to tack on an async runtime in order to use this crate has been a pet peeve of mine since v2!

@brotskydotcom brotskydotcom self-assigned this Jul 14, 2024
brotskydotcom added a commit to brotskydotcom/keyring-rs that referenced this issue Jul 14, 2024
Also clarify how per-credential store features work.

This fixes hwchen#189.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants