Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to only get the secret #130

Closed
jankatins opened this issue Jun 11, 2023 · 3 comments · Fixed by #134
Closed

Add a way to only get the secret #130

jankatins opened this issue Jun 11, 2023 · 3 comments · Fixed by #134
Assignees

Comments

@jankatins
Copy link

jankatins commented Jun 11, 2023

I want to use the example cli to interct with the keyrings on linux and mac and for that it would be nice to have a way to only return the password and not the The password for 'jan@jasc-one' is 'whatever'. Any chance to add such a cli interface? E.g. keyring-cli --service jasc-one get --password-only?

@brotskydotcom
Copy link
Collaborator

If you want to submit a pull request with this change, I'm happy to review it.

@jankatins
Copy link
Author

See #131

brotskydotcom added a commit to brotskydotcom/keyring-rs that referenced this issue Jun 20, 2023
The CLI was very chatty about its operations, which made it
unsuitable for use in scripts.  In addition, it always exited
with a success (0) status, even when operations failed.

This change fixes both of those issues:

1. The cli doesn't output anything to stdout except
when it retrieves a password successfully, in which case
the password (alone) is output followed by a newline.
2. The cli doesn't output anything to stderr unless
the -v (verbose) flag is specified, in which case it
prints debugging info to stderr on all operations.
3. The cli exits with status 0 only for success; if
an error is encountered it returns status 1.

Fixes hwchen#130.
@brotskydotcom
Copy link
Collaborator

Thanks for the PR! As I reviewed it, I realized that you also made another change (to return different exit statuses) that make the cli more suitable for scripted use. So I decided to go further than you had and have opened PR #134. Take a look and see if that does what you need.

@brotskydotcom brotskydotcom self-assigned this Jun 20, 2023
brotskydotcom added a commit that referenced this issue Jun 21, 2023
Make the cli suitable for scripting use. Fixes #130. Thanks to @jankatins for the suggestion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants