Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clusters clickable hurricane-response/response-theme#22 #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leckman
Copy link

@leckman leckman commented Oct 3, 2019

Description

Addresses issue #22

Makes clusters clickable - both on the shelters page and the distribution points page.
Code largely adapted from mapbox cluster documentation. Eventually, it would be nice to de-dupe code between those two layout pages.

On click, recenters map on clicked cluster centroid and zooms until the cluster splits up (either into more clusters or individual points).

Renamed ZOOM to INITIAL_ZOOM so it's obvious that variable is only used for initialization and doesn't store the state of the current zoom. Cleaned up some whitespace in the file.

c4a-hurricane

List of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • This pull request relates to a ticket.
  • This code is tested.
  • I want my code added to the response theme.

@leckman
Copy link
Author

leckman commented Oct 24, 2019

@nihonjinrxs not sure if you're the right person to tag - any idea on timeline for feedback here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant