-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coveralls integration #66
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon. |
6 similar comments
Some test cases fail, but they don't look related to my changes. In fact, they also fail with the master branch without my changes. |
Out of interest, what options are passed to kcov? I don't remember removing any command line option since v31, there are just a few added ones (speaking as the kcov developer). It would be great to just see the entire kcov command line from a failing run. There are improvements and bug fixes in kcov since v31, so it would be unfortunate to be stuck with that. That said, I agree fixing a version is good - the kcov HEAD is sometimes broken for obvious reasons. |
This PR uses v33 already. It turned out that the recent changes where not the cause of the problem. It was rather a combination of changes in rust and bugs in the codebase of travis-cargo. |
Any progress on this, @huonw ? |
I've posted this on internals: https://users.rust-lang.org/t/travis-cargo-status-and-future/9621 |
Is anyone trying to push that to the finish line? |
I have moved to this one: https://github.com/roblabla/cargo-travis/ |
Thanks @johanneskoester ! |
@huonw any plans on merging this and the other PRs? Even though this repo is no longer actively maintained, it would be nice if the community made fixes found a way into the main branch. |
This PR provides a fix for the broken coveralls integration.
This fixes issue #58.
Note that this PR subsumes #64, #61, and #55.