App would occasionally stop when trying to update prices #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure auctionInfo is an empty array
|
Looks good. It appears the builds are failing, most likely due to a linter error for the missing semi-colon. Add that in and I would be happy to merge. |
|
That seems to have fixed it. Thanks for app! |
|
Can you guys merge this fix? |
|
This needs to be pulled... |
Closed
|
App will be updated once #200 is merged in. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple if statement to verify whether prices were returned from the api so that it didn't try and use the prices variable on an empty object.