Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: improve radio item selection #927

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

huntabyte
Copy link
Owner

Closes #924

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 0137670

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview 0137670

@huntabyte huntabyte merged commit 1733412 into next Nov 14, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
@ctiospl
Copy link

ctiospl commented Nov 16, 2024

This change seems to trigger an onValueChange event when setting the currently selected value.
I switched back to an earlier version and its working as expected.

@huntabyte
Copy link
Owner Author

This change seems to trigger an onValueChange event when setting the currently selected value. I switched back to an earlier version and its working as expected.

What do you mean? Mind opening an issue with a reproduction so I can see what isn't working as expected?

@huntabyte huntabyte deleted the next-radio-item-autoselect branch November 16, 2024 17:11
@ctiospl
Copy link

ctiospl commented Nov 17, 2024

Sorry for just leaving a note, will open an issue with a reproduction. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants