Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: onpointerdown -> onclick #1011

Merged
merged 3 commits into from
Dec 19, 2024
Merged

next: onpointerdown -> onclick #1011

merged 3 commits into from
Dec 19, 2024

Conversation

huntabyte
Copy link
Owner

This PR reverts some changes to event handling made in a previous PR where we switched most of the onclick events to onpointerdown.

After some consideration and feedback, onclick makes the most sense in most places, however, we are keeping onpointerdown for the various menus/select/tabs where they make sense and feel better.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview 95a528e

@huntabyte huntabyte merged commit 6e31a3d into next Dec 19, 2024
5 checks passed
@huntabyte huntabyte deleted the next-cleanup-events branch December 31, 2024 02:28
This was referenced Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant