fix: Command.Root onStateChange not firing after first mount

huntabyte · Feb 11, 2025 · 5a4ae20 · 5a4ae20
1 parent 08566c8
commit 5a4ae20
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/hip-cycles-wait.md b/.changeset/hip-cycles-wait.md
@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+fix: `onStateChange` of `Command.Root` not firing after initial mount
diff --git a/packages/bits-ui/src/lib/bits/command/command.svelte.ts b/packages/bits-ui/src/lib/bits/command/command.svelte.ts
@@ -76,7 +76,7 @@ class CommandRootState {
 	_commandState = $state<CommandState>(null!);
 
 	#snapshot() {
-		return this._commandState;
+		return $state.snapshot(this._commandState);
 	}
 
 	#scheduleUpdate() {
@@ -91,7 +91,7 @@ class CommandRootState {
 
 			if (hasStateChanged) {
 				this.commandState = currentState;
-				this.opts.onStateChange?.current?.($state.snapshot(currentState));
+				this.opts.onStateChange?.current?.(currentState);
 			}
 		});
 	}