forked from vn-input/ibus-unikey
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPGRADE] build simple pipeline for testing automatically #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Check and load kernel module squashfs. - Fetch the latest release livecd - Extract and reconfigure this livecd - Compress to new livecd with configuration Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
Description: - Use qemu as the base environment to start regression test to verify release versions on multiple distros before push our product to marketplaces. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
Description: - Use lowercase name to match with the author's requirement Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
0395ad8
to
0e5889d
Compare
hung0913208
added a commit
that referenced
this pull request
May 26, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 26, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 26, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 27, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 28, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
added a commit
that referenced
this pull request
May 29, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
hung0913208
pushed a commit
that referenced
this pull request
May 31, 2020
Description: This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: - Create a lightweight pipeline inside file commit.yaml for testing with each commit, it uses another repository to support building a new generic pineline. Each commit must be proved to be passed with this pipeline. This pipeline is build within the github action to make a better maintaining and forking. - Create a heavy pipeline with UI testing inside. Still now, it only support ubuntu for testing and it's defined inside regression.yaml and .travis.yml. I don't suggest using github action since it doesn't support kvm which make the pipeline takes more time for verification. Signed-off-by: Hung Nguyen Xuan Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit suggests an automatically way to build a pipeline for testing ibus-unikey's commits or PR requests. Here is what i have done: