Use PHP CS Fixer

.github/workflows/php-cs-fixer.yml

@@ -0,0 +1,7 @@
+name: PHP CS Fixer
+
+on: push
+
+jobs:
+  tests:
+    uses: humhub/actions/.github/workflows/module-php-cs-fixer.yml@main

Assets.php

@@ -6,7 +6,6 @@
 
 class Assets extends AssetBundle
 {
-
     public $css = [
         'tasks.css',
     ];

CalendarUtils.php

@@ -17,15 +17,14 @@
  */
 class CalendarUtils
 {
-
-    const DATE_FORMAT = 'Y-m-d';
+    public const DATE_FORMAT = 'Y-m-d';
 
     /**
      *
      * @param DateTime $date1
      * @param DateTime $date2
      * @param type $endDateMomentAfter
-     * @return boolean
+     * @return bool
      */
     public static function isFullDaySpan(DateTime $date1, DateTime $date2, $endDateMomentAfter = false)
     {

Events.php

@@ -26,7 +26,6 @@
 use humhub\modules\tasks\models\user\TaskUser;
 use yii\db\Expression;
 
-
 /* @var $user \humhub\modules\user\models\User */
 
 /**
@@ -37,7 +36,6 @@
  */
 class Events
 {
-
     public static function onTopMenuInit($event)
     {
         try {
@@ -221,33 +219,33 @@ public static function onIntegrityCheck($event)
             }
         }
 
-//        // check for task responsible users without task or existing user
-//        foreach (TaskResponsible::find()->each() as $taskResponsible) {
-//            if ($taskResponsible->task === null) {
-//                if ($integrityController->showFix("Deleting task responsible user id " . $taskResponsible->id . " without existing task!")) {
-//                    $taskResponsible->delete();
-//                }
-//            }
-//            if ($taskResponsible->user === null) {
-//                if ($integrityController->showFix("Deleting task responsible user id " . $taskResponsible->id . " without existing user!")) {
-//                    $taskResponsible->delete();
-//                }
-//            }
-//        }
-
-//        // check for task assigned users without task or existing user
-//        foreach (TaskAssigned::find()->each() as $taskAssigned) {
-//            if ($taskAssigned->task === null) {
-//                if ($integrityController->showFix("Deleting task assigned user id " . $taskAssigned->id . " without existing task!")) {
-//                    $taskAssigned->delete();
-//                }
-//            }
-//            if ($taskAssigned->user === null) {
-//                if ($integrityController->showFix("Deleting task assigned user id " . $taskAssigned->id . " without existing user!")) {
-//                    $taskAssigned->delete();
-//                }
-//            }
-//        }
+        //        // check for task responsible users without task or existing user
+        //        foreach (TaskResponsible::find()->each() as $taskResponsible) {
+        //            if ($taskResponsible->task === null) {
+        //                if ($integrityController->showFix("Deleting task responsible user id " . $taskResponsible->id . " without existing task!")) {
+        //                    $taskResponsible->delete();
+        //                }
+        //            }
+        //            if ($taskResponsible->user === null) {
+        //                if ($integrityController->showFix("Deleting task responsible user id " . $taskResponsible->id . " without existing user!")) {
+        //                    $taskResponsible->delete();
+        //                }
+        //            }
+        //        }
+
+        //        // check for task assigned users without task or existing user
+        //        foreach (TaskAssigned::find()->each() as $taskAssigned) {
+        //            if ($taskAssigned->task === null) {
+        //                if ($integrityController->showFix("Deleting task assigned user id " . $taskAssigned->id . " without existing task!")) {
+        //                    $taskAssigned->delete();
+        //                }
+        //            }
+        //            if ($taskAssigned->user === null) {
+        //                if ($integrityController->showFix("Deleting task assigned user id " . $taskAssigned->id . " without existing user!")) {
+        //                    $taskAssigned->delete();
+        //                }
+        //            }
+        //        }
 
         // check for task reminders without task
         foreach (TaskReminder::find()->each() as $taskReminder) {
@@ -287,7 +285,7 @@ public static function onMemberRemoved($event)
                     }
                 }
             }
-        } catch(\Throwable $e) {
+        } catch (\Throwable $e) {
             Yii::error($e);
         }
     }

activities/Finished.php

@@ -6,7 +6,6 @@
 
 class Finished extends BaseActivity
 {
-
     public $moduleId = 'tasks';
     public $viewName = "finished";
 

activities/TaskCompletedActivity.php

@@ -13,7 +13,6 @@
 
 class TaskCompletedActivity extends BaseActivity
 {
-
     public $moduleId = 'tasks';
     public $viewName = "taskCompleted";
 

activities/TaskResetActivity.php

@@ -13,7 +13,6 @@
 
 class TaskResetActivity extends BaseActivity
 {
-
     public $moduleId = 'tasks';
     public $viewName = "taskReset";
 

activities/TaskReviewedActivity.php

@@ -13,7 +13,6 @@
 
 class TaskReviewedActivity extends BaseActivity
 {
-
     public $moduleId = 'tasks';
     public $viewName = "taskReviewed";
 

activities/TaskStartActivity.php

@@ -13,7 +13,6 @@
 
 class TaskStartActivity extends BaseActivity
 {
-
     public $moduleId = 'tasks';
     public $viewName = "taskStart";
 

assets/Assets.php

@@ -15,7 +15,6 @@
 
 class Assets extends AssetBundle
 {
-
     /**
      * @inheritDoc
      */

components/TaskHelper.php

@@ -18,7 +18,6 @@
  */
 class TaskHelper
 {
-
     public static function isOverdue(Task $task)
     {
         if (!$task->hasDeadline()) {

config.php

@@ -10,7 +10,7 @@
 use humhub\modules\space\models\Membership;
 use humhub\modules\user\widgets\ProfileMenu;
 
-return array(
+return [
     'id' => 'tasks',
     'class' => 'humhub\modules\tasks\Module',
     'namespace' => 'humhub\modules\tasks',
@@ -26,5 +26,5 @@
         ['class' => 'humhub\modules\calendar\interfaces\CalendarService', 'event' => 'getItemTypes', 'callback' => ['humhub\modules\tasks\Events', 'onGetCalendarItemTypes']],
         ['class' => 'humhub\modules\calendar\interfaces\CalendarService', 'event' => 'findItems', 'callback' => ['humhub\modules\tasks\Events', 'onFindCalendarItems']],
         ['class' => 'humhub\modules\rest\Module', 'event' => 'restApiAddRules', 'callback' => ['humhub\modules\tasks\Events', 'onRestApiAddRules']],
-    ]
-);
+    ],
+];

controllers/AbstractTaskController.php

@@ -53,7 +53,7 @@ public function actionExport($format)
         $query = $filterModel->query();
 
         $dataProvider = new ActiveDataProvider([
-            'query' => $query
+            'query' => $query,
         ]);
 
         $exporter = new SpreadsheetExport([
@@ -82,20 +82,20 @@ private function collectExportColumns($query)
             'description',
             [
                 'attribute' => 'Container',
-                'value' => $this->getRelatedContainer()
+                'value' => $this->getRelatedContainer(),
             ],
             [
                 'attribute' => 'ContainerType',
                 'value' =>  function ($model) {
                     /* @var $model \humhub\modules\tasks\models\Task */
                     return (new \ReflectionClass($model->content->container))->getShortName();
-                }
+                },
             ],
             [
                 'attribute' => 'ContainerId',
                 'value' =>  function ($model) {
                     return $model->content->container->id;
-                }
+                },
             ],
             [
                 'class' => DateTimeColumn::class,
@@ -121,24 +121,24 @@ private function collectExportColumns($query)
             'status',
             [
                 'attribute' => 'Checklist',
-                'value' => $this->getTaskItems($relationsData)
+                'value' => $this->getTaskItems($relationsData),
             ],
             [
                 'attribute' => 'Assigned Users',
-                'value' => $this->getAssignedUsers($relationsData)
+                'value' => $this->getAssignedUsers($relationsData),
             ],
             [
                 'attribute' => 'Responsible Users',
-                'value' => $this->getResponsibleUsers($relationsData)
+                'value' => $this->getResponsibleUsers($relationsData),
             ],
             [
                 'attribute' => 'Comments',
-                'value' => $this->getComments()
+                'value' => $this->getComments(),
             ],
             'color',
             [
                 'attribute' => 'review',
-                'label' => 'Review required'
+                'label' => 'Review required',
             ],
             'scheduling',
             'all_day',
@@ -147,8 +147,8 @@ private function collectExportColumns($query)
             'request_sent',
             [
                 'attribute' => 'task_list_id',
-                'label' => 'Task List'
+                'label' => 'Task List',
             ],
         ];
     }
-}
+}

controllers/ChecklistController.php

@@ -1,9 +1,7 @@
 <?php
 
-
 namespace humhub\modules\tasks\controllers;
 
-
 use humhub\modules\content\components\ContentContainerControllerAccess;
 use humhub\modules\space\models\Space;
 use humhub\modules\tasks\models\checklist\CheckForm;
@@ -19,21 +17,21 @@ class ChecklistController extends AbstractTaskController
     protected function getAccessRules()
     {
         return [
-            [ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]]
+            [ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]],
         ];
     }
 
     public function actionCheckItem($id, $taskId)
     {
         $model = new CheckForm(['itemId' => $id, 'taskId' => $taskId]);
-        if($model->load(Yii::$app->request->post()) && $model->save()) {
+        if ($model->load(Yii::$app->request->post()) && $model->save()) {
             return $this->asJson([
                 'success' => true,
                 'item' => [
                     'checked' => $model->checked,
                     'statusChanged' => $model->statusChanged,
-                    'sortOrder' => $model->item->sort_order
-                ]
+                    'sortOrder' => $model->item->sort_order,
+                ],
             ]);
         }
 

controllers/ConfigController.php

@@ -18,7 +18,7 @@
 use yii\web\HttpException;
 
 /**
- * 
+ *
  */
 class ConfigController extends Controller
 {
@@ -42,7 +42,7 @@ public function actionIndex()
         }
 
         return $this->render('snippet', [
-            'model' => $model
+            'model' => $model,
         ]);
     }
 }

controllers/GlobalController.php

@@ -25,14 +25,14 @@ class GlobalController extends AbstractTaskController
     protected function getAccessRules()
     {
         return [
-            [ControllerAccess::RULE_LOGGED_IN_ONLY]
+            [ControllerAccess::RULE_LOGGED_IN_ONLY],
         ];
     }
 
     public function actionIndex()
     {
         return $this->render('index', [
-            'filter' =>  new TaskFilter(['filters' => [TaskFilter::FILTER_ASSIGNED]])
+            'filter' =>  new TaskFilter(['filters' => [TaskFilter::FILTER_ASSIGNED]]),
         ]);
     }
 
@@ -43,7 +43,7 @@ public function actionFilter()
 
         return $this->asJson([
             'success' => true,
-            'result' => TaskSearchList::widget(['filter' => $filter])
+            'result' => TaskSearchList::widget(['filter' => $filter]),
         ]);
     }