Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending a message with attached files only, such as an image #424

Closed
marc-farre opened this issue Oct 9, 2024 · 5 comments
Closed

Comments

@marc-farre
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Sometimes, you just want to reply by sharing an image.

But currently, you have this error if you don't write some text:

Message cannot be blank.

Describe the solution you'd like

Allow sending a message with attached files without any text in the message field.

@marc-farre
Copy link
Contributor Author

@luke- If you agree with the idea, I can send a PR.

@luke-
Copy link
Contributor

luke- commented Oct 12, 2024

@marc-farre Sounds good to me. We have to consider the effects on notifications, though. But that should be fine.

@marc-farre
Copy link
Contributor Author

marc-farre commented Oct 13, 2024

@luke- PR #425 (notifications tested)

There is an error in the tests, but not related to this issue:

  1. NotificationTest: Notifications are sent after adding participant
    Test codeception/unit/NotificationTest.php:testNotificationsAreSentAfterAddingParticipant
    Failed asserting that two strings are equal.
  • Expected | + Actual
    @@ @@
    -'New message from Peter Tester'
    +'You joined the conversation.'

@luke-
Copy link
Contributor

luke- commented Oct 14, 2024

@marc-farre Thanks! Can you please take a look into the test as well?

@marc-farre
Copy link
Contributor Author

marc-farre commented Oct 15, 2024

@luke- I first thought it was a test error in the master branch, as it cannot be related to my changes, but as I have no error on my local dev instance, I re-runned the tests on GitHub, and now they pasted, without any extra commit.
So just a GitHub temporary bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants