-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support PHP 8.1 #543
Conversation
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
Co-Authored-By: Jacob Baker-Kretzmar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Do note that more work is required to add support for PHP 8.0 and 8.1 features, but that can definitely be done later incrementally. I need to finish some commitments towards the Alice related packages first, but I'll get to PHP-Scoper & Box ASAP afterwards. |
@theofidry Wondering if I can help you getting this project ready for PHP 8.1, or there is already a branch/work in progress? |
@nunomaduro #549 should answer your question and as well provide a bit more visibility about the state of things |
0.16.0 has been released with (partial) PHP 8.1.0 support |
Thanks so much @theofidry!! |
Thank you both 👏 |
Closes #530; supports box-project/box#562
This PR is not enough, but it's the foundation, of updating this package to work with PHP 8.1.
Other pieces:
SerializablePhpScoper
needs changes to its Serialization: PHP 8.1: SerializablePhpScoper needs implementation of magic methods box-project/box#571covers-validator
needs fixing, which I've PR'ed: Update for PHP 8.1 support oradwell/covers-validator#37 (that PR shows as closed, but it was reproduced by the author in Fix PHP 8.1 deprecations oradwell/covers-validator#39)Once those are fixed, we'll want to run
make test
and hope everything else works!