Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recording Oracle] Download exchange solutions and compare with the already uploaded #977

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

flopez7
Copy link
Contributor

@flopez7 flopez7 commented Oct 3, 2023

Description

Update webhook to receibe a file URL with the solutions instead of the solution directly and compare the solutions received with the already uploaded

Summary of changes

  1. Modify the previous docker configuration and remove postgres db
  2. Update webhook to receive SolutionUrl instead of solution
  3. Download the solutions uploaded by exchange oracle
  4. Compare the solutions with those already uploaded by recording oracle
  5. Check bad answers (duplicated an curse words)
  6. Upload new solutions to the same S3 solutions file
  7. Call exchange oracle webhook when invalid solution received

How test the changes

'yarn test'

Related issues

Close #950 #951

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@flopez7 flopez7 added the Oracles label Oct 3, 2023
@flopez7 flopez7 requested a review from portuu3 October 3, 2023 10:46
@flopez7 flopez7 self-assigned this Oct 3, 2023
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-protocol-typescript-sdk-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 10:52am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
fortune-exchange-oracle ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
fortune-exchange-oracle-server ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
fortune-job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
fortune-job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
fortune-recording-oracle ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
fortune-reputation-oracle ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am
job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:52am

@flopez7 flopez7 linked an issue Oct 3, 2023 that may be closed by this pull request
@flopez7 flopez7 linked an issue Oct 3, 2023 that may be closed by this pull request
@vercel vercel bot temporarily deployed to Preview – human-protocol-typescript-sdk-docs October 3, 2023 14:53 Inactive
@flopez7 flopez7 added the WIP Work In Progress label Oct 6, 2023
@flopez7 flopez7 removed the WIP Work In Progress label Oct 6, 2023
@vercel vercel bot temporarily deployed to Preview – human-protocol-typescript-sdk-docs October 6, 2023 09:04 Inactive
@portuu3 portuu3 added the WIP Work In Progress label Oct 10, 2023
@flopez7 flopez7 removed the WIP Work In Progress label Oct 10, 2023
@flopez7 flopez7 requested a review from portuu3 October 11, 2023 15:28
@flopez7 flopez7 merged commit 42db583 into develop Oct 13, 2023
@flopez7 flopez7 deleted the feat/recording/check-s3-solutions branch October 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recording Oracle] Notify bad solutions [Recording Oracle] Update webhook to receive the solutions file URL
2 participants