Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Job Launcher] - Client common fixes #885

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

m00n620
Copy link
Contributor

@m00n620 m00n620 commented Sep 13, 2023

Description

Common fixes for job launcher client v2.

Summary of changes

  • Fixed the network select on job table.
  • Fixed the status toggle buttons on job table.
  • Remove IMAGE_LABEL_BINARY request type
  • Add % constraint to accuracy target field. min=0, max=100, default=80
  • If the Job Launch Server is unavailable, handle the request error correctly.
  • Add url validation for "Data URL", "Ground truth URL" fields.
  • Add "User guide" field and url validation for it (design is updated on figma)

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escrow-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
faucet-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
fortune-exchange-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
fortune-exchange-oracle-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
fortune-job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
fortune-job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
fortune-recording-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
fortune-reputation-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 2:56pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2023 2:56pm

@m00n620 m00n620 changed the base branch from main to develop September 13, 2023 12:29
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 13, 2023 12:30 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 13, 2023 12:32 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 13, 2023 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 13, 2023 12:38 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 13, 2023 12:44 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 13, 2023 12:47 Inactive
@eugenvoronov
Copy link
Contributor

  • Logout does not work when the server is stopped.
Screenshot 2023-09-13 at 16 22 18
  • There no processing error if server is stopped.
Screenshot 2023-09-13 at 16 23 20

Copy link
Collaborator

@leric7 leric7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just couple NITs.

@portuu3
Copy link
Collaborator

portuu3 commented Sep 14, 2023

I think we should add all networks here
image

If for example I click on Launched then choose a network and then click on Cancelled, the dropdown is not reseted and it is not filtering.

@Dzeranov
Copy link
Contributor

Dzeranov commented Sep 14, 2023

  1. With this default value it's not clear what is this field for
image
  1. Please, check figma design for CVAT job creation.

@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 14, 2023 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 14, 2023 13:30 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 14, 2023 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 14, 2023 13:33 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 14, 2023 13:34 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 14, 2023 13:35 Inactive
leric7
leric7 previously approved these changes Sep 15, 2023
Copy link
Collaborator

@leric7 leric7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 15, 2023 13:30 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 15, 2023 13:33 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 15, 2023 13:36 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 15, 2023 13:38 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 15, 2023 13:47 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 15, 2023 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 15, 2023 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 15, 2023 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 15, 2023 14:51 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 15, 2023 14:52 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 15, 2023 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 15, 2023 14:55 Inactive
@m00n620 m00n620 requested a review from leric7 September 15, 2023 20:46
@m00n620 m00n620 merged commit e1cc816 into develop Sep 18, 2023
@leric7 leric7 deleted the feat/launcher/client/common-fixes branch September 19, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants