[Job Launcher] Refactor nested services dependencies #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vercel
bot
temporarily deployed
to
Preview – fortune-job-launcher-client
vercel
bot
temporarily deployed
to
Preview – fortune-reputation-oracle
portuu3
approved these changes
Aug 3, 2023
portuu3
added a commit
that referenced
this pull request
Aug 9, 2023
* Auth refactor JL * authentication fixes * remove jwt interface * fix tests and clean code * fix review comments * Refactored services and removed unnecessary nesting (#747) * database and payment fixes (#743) Co-authored-by: Eugene Voronov <[email protected]> * use of access and refresh tokens for auth * fix tests * make sure token contains bearer * rename jwt prefix --------- Co-authored-by: Francisco López <[email protected]> Co-authored-by: eugenvoronov <[email protected]> Co-authored-by: Eugene Voronov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nested dependencies of services was refactor, for example, where it is possible to used the repository directly.
Summary of changes
Payment Repositorydirectly to theJob Servicesave paymentmethod formPayment ServiceCurrency Serviceand use until insteadHow test the changes
yarn testRelated issues
[Job Launcher] Refactoring nested services dependencies#746