[HUM-159]: refactor component sign up component refactor #3157
Conversation
|
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
|
@dnechay ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -342,7 +342,7 @@ | |||
| }, | |||
| "connectWallet": { | |||
| "title": "Setup Operator", | |||
| "description": "Please use the button bellow to connect your wallet and sign up as an operator.", | |||
| "description": "Please use the button below to connect your wallet and sign up as an operator.", | |||
| keysData: GetEthKVStoreValuesSuccessResponse; | ||
| }>) { | ||
| const hasSomeNotEmptyKeys = | ||
| Object.values(keysData).filter(Boolean).length > 0; |
There was a problem hiding this comment.
| Object.values(keysData).filter(Boolean).length > 0; | |
| Object.values(keysData).some(Boolean); |
| Object.values(keysData).filter((value) => { | ||
| /** | ||
| * This check is necessary because TS can't infer | ||
| * "undefined" from optional object's property | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| if (value === undefined) { | ||
| return false; | ||
| } | ||
|
|
||
| return value.length === 0; | ||
| }).length > 0; |
There was a problem hiding this comment.
| Object.values(keysData).filter((value) => { | |
| /** | |
| * This check is necessary because TS can't infer | |
| * "undefined" from optional object's property | |
| */ | |
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | |
| if (value === undefined) { | |
| return false; | |
| } | |
| return value.length === 0; | |
| }).length > 0; | |
| Object.values(keysData).some((value) => { | |
| /** | |
| * This check is necessary because TS can't infer | |
| * "undefined" from optional object's property | |
| */ | |
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | |
| if (value === undefined) { | |
| return false; | |
| } | |
| return value.length === 0; | |
| }); |
| useHMTokenDecimals, | ||
| } from '../hooks'; | ||
| import { StakeForm, Buttons } from '../components/add-stake'; | ||
| import { stakedAmountFormatter } from '../utils'; |
There was a problem hiding this comment.
A bit below in getAlert, let's maybe do switch based on addStakeMutationState?.status instead of true?
There was a problem hiding this comment.
Also let's do something similar in ConnectWalletOperatorPage component
|
|
||
| type AmountField = z.infer<AmountValidation>; | ||
|
|
||
| export const addStakeAmountCallArgumentsSchema = ( |
There was a problem hiding this comment.
schema is not a util, it's actually a schema, so let's either move them to some signup/operator/schemas
There was a problem hiding this comment.
Yes, I was a bit unsure about how we want to store that, will do!
Issue tracking
HUM-159
Context behind the change
homepage/signup/operatorHow has this been tested?
Release plan
normal
Potential risks; What to monitor; Rollback plan
n/a