fix: allow governance execution without dao spoke contract #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
portuu3
reviewed
Feb 24, 2025
portuu3
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
Context behind the change
While Governance is designed to support cross-chain voting, we still want to support voting only on hub chain.
Current vote collection flow is only working when there are spoke contracts, and wormhole relayer is properly configured.
This changes allows us to finish collection phase only on hub chain after the vote ends, when there are no dao spoke contracts.
How has this been tested?
I added a new test case for governance contract to execute the proposal, without dao spoke contracts deployed.
Release plan
Potential risks; What to monitor; Rollback plan