Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUM-170]: fix: error notification is displayed twice when should be once #3110

Conversation

mpblocky
Copy link
Contributor

Issue tracking

Closes: HUM-170

Context behind the change

  • Added wallet connect initialization check
  • Relaxed isReady condition as the mutation.data could be empty

How has this been tested?

  • tested the expected behaviour on production build

Release plan

normal

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Feb 21, 2025

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@mpblocky
Copy link
Contributor Author

@dnechay fix ready :)

@dnechay dnechay self-requested a review February 21, 2025 10:04
@mpblocky mpblocky requested a review from dnechay February 21, 2025 11:12
Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 1:04pm

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lgtm, but wallet connect functionality is broken for operator now

@mpblocky
Copy link
Contributor Author

mpblocky commented Feb 21, 2025

image

@dnechay I added this notification as well, becuase there was just a misleading "cannot sign message" when user had invalid network selected in the web3 provider.

I'm looking into the operator problem, where exactly?

@dnechay
Copy link
Contributor

dnechay commented Feb 21, 2025

I added this notification as well, becuase there was just a misleading "cannot sign message" when user had invalid network selected in the web3 provider.

@mpblocky great addition, thank you!

I'm looking into the operator problem, where exactly?

On the main page, regular "Operator Sign In" button doesn't work for the account I have on STG. Same for "Sign Up". I suppose other functionality might be affected as well (if any)

@mpblocky
Copy link
Contributor Author

@dnechay thanks, I will investigate and check other places that could get affected

@mpblocky
Copy link
Contributor Author

@dnechay reverting the changes in wallet connect context were sufficient, so no regression tests are needed as changes in worker profile were enough to fix the notification problem :)

@dnechay dnechay merged commit 060c601 into humanprotocol:develop Feb 21, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Feb 21, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants