-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUM-170]: fix: error notification is displayed twice when should be once #3110
[HUM-170]: fix: error notification is displayed twice when should be once #3110
Conversation
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
@dnechay fix ready :) |
packages/apps/human-app/frontend/src/shared/contexts/wallet-connect/wallet-connect.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/worker/components/profile/profile.page.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/worker/components/profile/profile.page.tsx
Outdated
Show resolved
Hide resolved
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix lgtm, but wallet connect functionality is broken for operator now
@dnechay I added this notification as well, becuase there was just a misleading "cannot sign message" when user had invalid network selected in the web3 provider. I'm looking into the operator problem, where exactly? |
@mpblocky great addition, thank you!
On the main page, regular "Operator Sign In" button doesn't work for the account I have on STG. Same for "Sign Up". I suppose other functionality might be affected as well (if any) |
@dnechay thanks, I will investigate and check other places that could get affected |
This reverts commit 90c5a39.
@dnechay reverting the changes in wallet connect context were sufficient, so no regression tests are needed as changes in worker profile were enough to fix the notification problem :) |
Issue tracking
Closes: HUM-170
Context behind the change
isReady
condition as themutation.data
could be emptyHow has this been tested?
Release plan
normal
Potential risks; What to monitor; Rollback plan
N/A