-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reputation Oracle] refactor: common folder cleanup #3095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
16 tasks
Dzeranov
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
It might be easier to review it commit-by-commit for some parts
Issue tracking
Part of #3084
Context behind the change
e2e
removed because not used; we might want set up it later from scratchapp.controller
, we have specific routesSnakeCaseInterceptor
refactored toTransformInterceptor
so it's clear that it's used for transforming request/response; also made case transformers clear by refactoring code, adding unit tests and removing implicit logic ondate. toISOString
index.ts
files instead of separate "one function file", so now we keep it simple, later can group things if they appeartest/mock-creators
; later would be nice to havefixtures
there alreadyHow has this been tested?
Release plan
Test & merge
Potential risks; What to monitor; Rollback plan
Should be no risks. The only new change is related to values case transformation, but it extends APIs, not reduces what they acceps.