Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reputation Oracle] Email service refactoring #3089

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

Dzeranov
Copy link
Contributor

@Dzeranov Dzeranov commented Feb 10, 2025

Issue tracking

Part of the #3084

Context behind the change

Introducing EmailService which provides a common interface for sending emails.
Under the hood it uses SendgridEmailService which could be easily replaced in the future by any other email provider without affecting source code.
Tests rewritten from scratch, faker is being used for generating data.

How has this been tested?

  • Unit tests for sendgrid.service.ts
  • Changed unit tests in auth module
  • Locally deployed and tested the affected code (should log in dev mode, send an email in stg/prod)

Release plan

Envs:

  1. SENDGRID_FROM_EMAIL -> EMAIL_FROM
  2. SENDGRID_FROM_NAME -> EMAIL_FROM_NAME
  • Staging
  • Production

Potential risks; What to monitor; Rollback plan

TBD

@Dzeranov Dzeranov self-assigned this Feb 10, 2025
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:52am
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:52am
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:52am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 0:52am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 0:52am

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Dzeranov Dzeranov merged commit 3eaecdb into develop Feb 11, 2025
12 checks passed
@Dzeranov Dzeranov deleted the dzeranov/3084-sendgrid branch February 11, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants