[Job Launcher] Fixed case transformation issue for request body properties in "Failed" webhooks #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
dnechay
reviewed
Jan 30, 2025
packages/apps/reputation-oracle/server/src/modules/webhook/webhook.controller.ts
Outdated
Show resolved
Hide resolved
I think I can add some unit test for this case, I will check |
dnechay
reviewed
Jan 31, 2025
packages/apps/fortune/exchange-oracle/server/src/modules/job/job.controller.ts
Show resolved
Hide resolved
packages/apps/fortune/exchange-oracle/server/src/modules/webhook/webhook.controller.ts
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/common/guards/signature.auth.ts
Outdated
Show resolved
Hide resolved
...ps/fortune/exchange-oracle/server/src/common/interceptors/transform-enum.interceptor.spec.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
The issue was tracked on GitHub under issue [Job Launcher] Failing to transform case of request body properties for "failed" webhooks
#3039
Context behind the change
Job Launcher (and other services with similar transformation logic) was failing to processing nested objects.
The issue occurs because
instance[property]might be undefined whenbodyOrQuery[property]is an object, causing an error when trying to accessinstance[property][nestedKey].Release plan
This change can be deployed as part of the regular deployment cycle.