Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reputation Oracle] Refactor User module error handling #3042

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

Dzeranov
Copy link
Contributor

@Dzeranov Dzeranov commented Jan 24, 2025

Issue tracking

Subtask of a #2928

Context behind the change

  1. Changed error handling in User module.
  2. Removed unused code.
  3. Refactored tests (removed some mocks, etc.)
  4. Partially removed Credentials functionality. Will be deleted as a part of [Reputation Oracle] Remove Credentials module #3045

How has this been tested?

DO NOT MERGE TILL THIS IS CHECKED

  • Deploy this branch to staging and test after the initial review.

Release plan

N/A

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:27pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:27pm
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 1:27pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 1:27pm

@Dzeranov Dzeranov marked this pull request as ready for review January 24, 2025 12:33
@Dzeranov Dzeranov marked this pull request as draft January 24, 2025 12:33
@Dzeranov Dzeranov marked this pull request as ready for review January 27, 2025 09:10
@Dzeranov Dzeranov requested review from dnechay and portuu3 January 27, 2025 09:10
@Dzeranov Dzeranov marked this pull request as draft January 27, 2025 09:12
@Dzeranov Dzeranov marked this pull request as ready for review January 27, 2025 10:01
@Dzeranov Dzeranov requested review from portuu3 and dnechay January 27, 2025 10:02
dnechay
dnechay previously approved these changes Jan 27, 2025
@Dzeranov Dzeranov added the do-not-merge PR shouldn't be merged until this label is removed label Jan 27, 2025
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✔️

@Dzeranov Dzeranov removed the do-not-merge PR shouldn't be merged until this label is removed label Jan 29, 2025
@Dzeranov Dzeranov merged commit 6ed367e into develop Jan 29, 2025
12 checks passed
@dnechay dnechay deleted the dzeranov/2928-user branch January 29, 2025 13:29
@Dzeranov Dzeranov mentioned this pull request Jan 29, 2025
35 tasks
@Dzeranov Dzeranov self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants