Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUM-97: refactor sign in page #3023

Merged

Conversation

adrian-oleskiewicz
Copy link
Contributor

@adrian-oleskiewicz adrian-oleskiewicz commented Jan 17, 2025

Issue tracking

HUM-97

Context behind the change

Split page component into components, hooks, utils

How has this been tested?

checked if it's possible to log in
checked the error message on log in with invalid credentials

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 17, 2025

Someone is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@adrian-oleskiewicz adrian-oleskiewicz marked this pull request as ready for review January 22, 2025 07:45
@adrian-oleskiewicz
Copy link
Contributor Author

@dnechay ready to review

@dnechay dnechay self-requested a review January 22, 2025 14:37
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "How has this been tested?" please don't just write "manually", write about some step you took to test the code or test-cases you accomplished, e.g.:

  • attempted to sign in with invalid password - error is shown

or

  • success sign-in case

(example PR with filled testing section)

@dnechay
Copy link
Contributor

dnechay commented Jan 30, 2025

@mpblocky ^

@mpblocky mpblocky force-pushed the HUM-97-refactor-sign-in branch from 1302f61 to cdd3c3b Compare January 31, 2025 14:36
@mpblocky
Copy link
Contributor

@dnechay resolved conflicts :)

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:28am

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpblocky
By analogy with sign-up module, let's move sing-in.page to signin/worker module, so everything is there?

@mpblocky
Copy link
Contributor

mpblocky commented Feb 4, 2025

@dnechay rearranged files

@dnechay dnechay merged commit 33d3a1d into humanprotocol:develop Feb 4, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Feb 4, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants