-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HUM-97: refactor sign in page #3023
HUM-97: refactor sign in page #3023
Conversation
Someone is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
@dnechay ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In "How has this been tested?" please don't just write "manually", write about some step you took to test the code or test-cases you accomplished, e.g.:
- attempted to sign in with invalid password - error is shown
or
- success sign-in case
packages/apps/human-app/frontend/src/modules/worker/components/sign-in/sign-in-form.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/worker/hooks/use-sign-in.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/worker/utils/formatted-sign-in-error-message.ts
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/worker/components/sign-in/sign-in-form.tsx
Outdated
Show resolved
Hide resolved
1302f61
to
cdd3c3b
Compare
@dnechay resolved conflicts :) |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mpblocky
By analogy with sign-up
module, let's move sing-in.page
to signin/worker
module, so everything is there?
@dnechay rearranged files |
Issue tracking
HUM-97
Context behind the change
Split page component into components, hooks, utils
How has this been tested?
checked if it's possible to log in
checked the error message on log in with invalid credentials
Release plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A