-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUM-131]: chore: redistribute code from color mode context #3006
[HUM-131]: chore: redistribute code from color mode context #3006
Conversation
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
packages/apps/human-app/frontend/src/shared/helpers/dark-mode.ts
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/helpers/dark-mode.ts
Outdated
Show resolved
Hide resolved
@dnechay PR ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep everything relaetd to ColorMode
context in one folder: shared/contexts/color-mode
packages/apps/human-app/frontend/src/shared/helpers/dark-mode.ts
Outdated
Show resolved
Hide resolved
d1e6205
to
602acb2
Compare
@dnechay everything addressed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, left some suggestions
packages/apps/human-app/frontend/src/shared/contexts/color-mode/color-mode-settings.ts
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/contexts/color-mode/color-mode.tsx
Outdated
Show resolved
Hide resolved
602acb2
to
ec0d2ef
Compare
@dnechay fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve merge conflicts
packages/apps/human-app/frontend/src/shared/contexts/color-mode/color-mode-settings.ts
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/contexts/color-mode/color-mode-handlers.ts
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/contexts/color-mode/color-mode-handlers.ts
Outdated
Show resolved
Hide resolved
746c612
to
a4f62a2
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Issue tracking
HUM-131
Context behind the change
How has this been tested?
Release plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A