Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUM-131]: chore: redistribute code from color mode context #3006

Conversation

mpblocky
Copy link
Contributor

@mpblocky mpblocky commented Jan 13, 2025

Issue tracking

HUM-131

Context behind the change

  • Redistributed files of color mode context

How has this been tested?

  • checked if the dark mode is switching correctly

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 13, 2025

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@mpblocky mpblocky marked this pull request as ready for review January 27, 2025 13:25
@mpblocky
Copy link
Contributor Author

@dnechay PR ready

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep everything relaetd to ColorMode context in one folder: shared/contexts/color-mode

@mpblocky mpblocky force-pushed the HUM-131-refactor-context-code-split-color-mode-context branch 2 times, most recently from d1e6205 to 602acb2 Compare January 28, 2025 12:01
@mpblocky mpblocky requested a review from dnechay January 28, 2025 12:02
@mpblocky
Copy link
Contributor Author

@dnechay everything addressed :)

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left some suggestions

@mpblocky mpblocky force-pushed the HUM-131-refactor-context-code-split-color-mode-context branch from 602acb2 to ec0d2ef Compare January 30, 2025 08:30
@mpblocky mpblocky requested a review from dnechay January 30, 2025 09:36
@mpblocky
Copy link
Contributor Author

@dnechay fixed!

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts

@mpblocky mpblocky force-pushed the HUM-131-refactor-context-code-split-color-mode-context branch from 746c612 to a4f62a2 Compare January 30, 2025 15:03
@mpblocky mpblocky requested a review from dnechay January 30, 2025 15:03
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:42pm

@dnechay dnechay merged commit 376526d into humanprotocol:develop Jan 30, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Jan 30, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants