[HUM-132]: chore: separate homepage state hook from context

[mpblocky]

Issue tracking

HUM-132

Context behind the change

• Separate hook from context

How has this been tested?

• checked if home page state is correctly provided (e.g. "how it works" in navbar) and functions depending on it are behaving same as before

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

[vercel]

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

[mpblocky]

@dnechay PR ready!

[dnechay]

Nice optimization of context with useMemo

Do we really need to move useHomePageState to shared/hooks? IMO it will only clutter shared/hooks folder.

I would suggest to have shared/contexts/homepage-state folder with internal files like:

• homepage-state.ts
• types.ts (seems to be excessive for now, HomePageStateType can be places in context file itself because not used anywhere else so there is no need to even export it)
• use-homepage-state.ts - hook
• index.ts - from where you re-export hook and context

wdyt?

[mpblocky]

@dnechay I'm not sure about keeping hook in there; do You want to keep context hooks near the context and some more general hooks in shared/hooks?

[dnechay]

@mpblocky

do You want to keep context hooks near the context and some more general hooks in shared/hooks?

Yes: IMO it's cleaner for our use case, because we don't have many different contexts that we use at the same time in different components and if we co-locate these hooks near to their contexts - it's easier to find things.

In case you anticipate there might be some complex use-cases - then I would keep them in shared/hooks/context

I believe it's better to keep things simple and straightforward till the moment you actually see there is a complex use-case and you need to refactor for it

As an example of a "complex" use case: you might want to have some useColorModeContext hook, that will:

• attempt to get some shared context first
• if the above is not available - try to check browser settings
• if the above is "default" - provide some custom default value
  In this "complex" case you don't just use the same context you defined, you have some extra logic. In this case it's good to place this complex useColorModeContext into some shared/hooks/context folder. But in case you just "get or throw" - it's better to keep it simple and in the same place

[mpblocky]

@dnechay yes, this sounds good, just wanted to be sure we are on the same page :)

[mpblocky]

@dnechay fixed :)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
human-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 3:55pm