-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUM-129]: chore: redistribute background context files #3003
[HUM-129]: chore: redistribute background context files #3003
Conversation
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
@dnechay PR ready, will resolve conflicts after the review |
0320869
to
2e12932
Compare
@dnechay addressed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hook called useBackgroundColorContext
, but contexts/background
folder and BackgroundProvider
. Would be nice to have some consistency in naming, either useBackgroundContext
or BackgroundColorProvider
(and etc.)
Other changes lgtm
18a1270
to
284249f
Compare
@dnechay fixed! |
packages/apps/human-app/frontend/src/shared/contexts/background/use-background-context.tsx
Outdated
Show resolved
Hide resolved
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
@mpblocky please resolve merge conflicts
c907d2d
to
9557da9
Compare
Issue tracking
HUM-129
Context behind the change
How has this been tested?
Release plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A