Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUM-129]: chore: redistribute background context files #3003

Conversation

mpblocky
Copy link
Contributor

@mpblocky mpblocky commented Jan 13, 2025

Issue tracking

HUM-129

Context behind the change

  • Redistributed files of background context

How has this been tested?

  • checked if the dark mode is switching correctly

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 13, 2025

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@mpblocky mpblocky marked this pull request as ready for review January 27, 2025 13:11
@mpblocky
Copy link
Contributor Author

@dnechay PR ready, will resolve conflicts after the review

@mpblocky mpblocky force-pushed the HUM-129-refactor-context-refactor-background-color-store branch from 0320869 to 2e12932 Compare January 28, 2025 12:49
@mpblocky
Copy link
Contributor Author

@dnechay addressed :)

@dnechay dnechay self-requested a review January 28, 2025 15:23
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook called useBackgroundColorContext, but contexts/background folder and BackgroundProvider. Would be nice to have some consistency in naming, either useBackgroundContext or BackgroundColorProvider (and etc.)

Other changes lgtm

@mpblocky mpblocky force-pushed the HUM-129-refactor-context-refactor-background-color-store branch from 18a1270 to 284249f Compare January 30, 2025 08:19
@mpblocky
Copy link
Contributor Author

@dnechay fixed!

@mpblocky mpblocky requested a review from dnechay January 30, 2025 09:37
@mpblocky mpblocky requested a review from dnechay January 30, 2025 14:58
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:46pm

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM
@mpblocky please resolve merge conflicts

@mpblocky mpblocky force-pushed the HUM-129-refactor-context-refactor-background-color-store branch from c907d2d to 9557da9 Compare January 31, 2025 08:16
@mpblocky mpblocky requested a review from dnechay January 31, 2025 08:16
@mpblocky mpblocky requested a review from dnechay January 31, 2025 12:00
@dnechay dnechay merged commit 0ebfaf8 into humanprotocol:develop Jan 31, 2025
3 of 8 checks passed
@dnechay dnechay mentioned this pull request Jan 31, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants