-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUM-134]: chore: redistribute shared wallet connect files #3000
[HUM-134]: chore: redistribute shared wallet connect files #3000
Conversation
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
d193b71
to
74200c4
Compare
packages/apps/human-app/frontend/src/shared/contexts/wallet-connect.tsx
Outdated
Show resolved
Hide resolved
@dnechay this is ready for CR as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on types and optimization!
I would suggest to have shared/contexts/wallet-connect
folder with internal files like:
wallet-connect.ts
types.ts
use-wallet-connect.ts
- hookindex.ts
- from where you re-export hook, context and types
wdyt?
packages/apps/human-app/frontend/src/shared/contexts/wallet-connect.tsx
Outdated
Show resolved
Hide resolved
c2d53d9
to
cee810b
Compare
@dnechay everything ready |
packages/apps/human-app/frontend/src/modules/auth-web3/hooks/use-connected-wallet.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/modules/auth-web3/hooks/use-connected-wallet.tsx
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/contexts/wallet-connect/wallet-connect.tsx
Outdated
Show resolved
Hide resolved
since signMessage is always defined the optional property operator was removed and with that: undefined check in hook
c4d1445
to
ad1074c
Compare
@dnechay fixed! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Issue tracking
HUM-134
Context behind the change
How has this been tested?
Release plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A