Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUM-134]: chore: redistribute shared wallet connect files #3000

Conversation

mpblocky
Copy link
Contributor

@mpblocky mpblocky commented Jan 13, 2025

Issue tracking

HUM-134

Context behind the change

  • Redistributed files of wallet connect

How has this been tested?

  • checked if wallet connect login is possible

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 13, 2025

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@mpblocky mpblocky force-pushed the HUM-134-refactor-context-refactor-wallet-connect branch from d193b71 to 74200c4 Compare January 16, 2025 13:48
@mpblocky mpblocky marked this pull request as ready for review January 24, 2025 13:14
@mpblocky
Copy link
Contributor Author

@dnechay this is ready for CR as well

@dnechay dnechay self-requested a review January 24, 2025 14:36
Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on types and optimization!

I would suggest to have shared/contexts/wallet-connect folder with internal files like:

  • wallet-connect.ts
  • types.ts
  • use-wallet-connect.ts - hook
  • index.ts - from where you re-export hook, context and types

wdyt?

@mpblocky mpblocky force-pushed the HUM-134-refactor-context-refactor-wallet-connect branch from c2d53d9 to cee810b Compare January 28, 2025 12:53
@mpblocky mpblocky requested a review from dnechay January 28, 2025 13:04
@mpblocky
Copy link
Contributor Author

@dnechay everything ready

@mpblocky mpblocky force-pushed the HUM-134-refactor-context-refactor-wallet-connect branch from c4d1445 to ad1074c Compare January 30, 2025 08:28
@mpblocky
Copy link
Contributor Author

@dnechay fixed!

@mpblocky mpblocky requested a review from dnechay January 30, 2025 09:37
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:54am

@dnechay dnechay merged commit 1d04bcf into humanprotocol:develop Jan 30, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Jan 30, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants