-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUM-128]: chore: split hcaptcha components to separate files #2991
Merged
dnechay
merged 4 commits into
humanprotocol:develop
from
KacperKoza343:HUM-128-refactor-components-code-split-h-captcha
Jan 23, 2025
Merged
[HUM-128]: chore: split hcaptcha components to separate files #2991
dnechay
merged 4 commits into
humanprotocol:develop
from
KacperKoza343:HUM-128-refactor-components-code-split-h-captcha
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
@dnechay ready for review |
dnechay
reviewed
Jan 13, 2025
packages/apps/human-app/frontend/src/shared/components/hcaptcha/h-captcha.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/hcaptcha/h-captcha.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/hcaptcha/h-captcha-form.tsx
Outdated
Show resolved
Hide resolved
e31b1df
to
8b2f9aa
Compare
@dnechay PR ready! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dnechay
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here! Looks much better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
HUM-128
Context behind the change
Refactor:
useImperativeHandle
to expose captcha'sreset
functionHow has this been tested?
Checked if captcha behaves the same as before the changes; if it works correctly for login, if it resets after filling the form and clicking "forgot password"
Release plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A