Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUM-128]: chore: split hcaptcha components to separate files #2991

Conversation

mpblocky
Copy link
Contributor

@mpblocky mpblocky commented Jan 10, 2025

Issue tracking

HUM-128

Context behind the change

Refactor:

  • used useImperativeHandle to expose captcha's reset function
  • changed names to more meaningful

How has this been tested?

Checked if captcha behaves the same as before the changes; if it works correctly for login, if it resets after filling the form and clicking "forgot password"

Release plan

normal deploy

Potential risks; What to monitor; Rollback plan

N/A

Copy link

vercel bot commented Jan 10, 2025

@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@mpblocky mpblocky changed the title chore: split hcaptcha components to separate files [HUM-128]: chore: split hcaptcha components to separate files Jan 13, 2025
@mpblocky mpblocky marked this pull request as ready for review January 13, 2025 09:10
@mpblocky
Copy link
Contributor Author

@dnechay ready for review

@dnechay dnechay self-requested a review January 13, 2025 10:02
@mpblocky mpblocky marked this pull request as draft January 16, 2025 11:12
@mpblocky mpblocky force-pushed the HUM-128-refactor-components-code-split-h-captcha branch from e31b1df to 8b2f9aa Compare January 22, 2025 08:52
@mpblocky mpblocky marked this pull request as ready for review January 22, 2025 14:37
@mpblocky
Copy link
Contributor Author

@dnechay PR ready!

@dnechay dnechay self-requested a review January 22, 2025 14:45
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:52am

Copy link
Contributor

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here! Looks much better

@dnechay dnechay merged commit b7554f0 into humanprotocol:develop Jan 23, 2025
5 of 9 checks passed
@dnechay dnechay mentioned this pull request Jan 23, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants