[HUM-127]: chore: refactor page card components #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpblocky is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card-loader.tsx
Outdated
Show resolved
Hide resolved
mpblocky
changed the title
|
@dnechay ready for review |
dnechay
requested review from
dnechay
and removed request for
adrian-oleskiewicz
dnechay
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Let's have page-card/index.ts that re-exports necessary components, so they can be imported easily in on import statement, i.e.
import {
PageCardError,
PageCardLoader
} from '@/shared/components/ui/page-card';
instead of
import { PageCardError } from '@/shared/components/ui/page-card/page-card-error';
import { PageCardLoader } from '@/shared/components/ui/page-card/page-card-loader';
packages/apps/human-app/frontend/src/shared/components/ui/page-card/consts.ts
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card-loader.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card-error.tsx
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
migace
reviewed
Jan 16, 2025
...ages/apps/human-app/frontend/src/modules/homepage/components/choose-sign-up-account-type.tsx
Outdated
Show resolved
Hide resolved
This reverts commit 367ab54.
mpblocky
force-pushed
the
HUM-127-refactor-components-refactor-page-card-components
branch
from
a23d85e to
60fc02f
Compare
|
@dnechay this one is ready for re-review :) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dnechay
reviewed
Jan 23, 2025
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
packages/apps/human-app/frontend/src/shared/components/ui/page-card/page-card.tsx
Outdated
Show resolved
Hide resolved
|
@dnechay applied suggestions, I think it looks good now :) |
|
All done @dnechay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue tracking
HUM-127
Context behind the change
How has this been tested?
withLayoutBackground- manually checked on mocked page, how do each ofpage-card*.tsxlookRelease plan
normal deploy
Potential risks; What to monitor; Rollback plan
N/A