[Governance] Audit changes

[mrhouzlane]

Description

Governance contract changes requests from Certik Audit.

Summary of changes

• SRC-10 : add custom errors here
• MHG-08: Change made in MetaHumanGovernor constructor params.
• CCG-01: Not subject to a check anymore.
• CCG-04: Fix Unnecessary read access storage here
• SRS-01: Replace transfer by sendValue from OZ : here and here
• SRC-09 : Usage of third party services like Wormhole may occur in downtime on their side. Implementing regular checks on the Wormhole Automatic Relayer is an option here.
• MHG-11: We decided to add a withdraw functions in Hub and Spoke contracts.
• MHG-10: Skipped - not necessary.
• MHG-06: Cancel proposal synced on hub and spokes here
• MHG-03: Unsafe Integer Cast: Ethereum addresses are always within the range of uint160, using SafeCast.toUint160 for address casting is not necessary here. - skipped.
• SRC-07: The clock mode (ERC6372) is an optional change and will be made in future version release. No change in this version.
• MHG-05: The clock mode (ERC6372) is an optional change and will be made in future version release. No change in this version.
• DAO-02: The clock mode (ERC6372) is an optional change and will be made in future version release. No change in this version.
• SRC-06: [Internal discussion] - noticed - A blog will be written down for this issue.

Closes #1645

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
escrow-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Mar 4, 2024 0:56am
faucet-server	⬜️ Ignored (Inspect)	Visit Preview		Mar 4, 2024 0:56am
job-launcher-client	⬜️ Ignored (Inspect)	Visit Preview		Mar 4, 2024 0:56am
job-launcher-server	⬜️ Ignored (Inspect)	Visit Preview		Mar 4, 2024 0:56am