Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job launcher fixes #1593

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Job launcher fixes #1593

merged 2 commits into from
Feb 14, 2024

Conversation

portuu3
Copy link
Collaborator

@portuu3 portuu3 commented Feb 14, 2024

Description

Job launcher fixes:

  • Change env PGP_ENCRYPT to boolean
  • Add beforeInsert to CronJobEntity. It was trying to insert null value for started_at column, so threw an error.
  • Use eq comparer for amounts comparisson. Before it didn't work properly when comparing decimal values for example 1.010000000000000000 and 1.01

@portuu3 portuu3 requested a review from flopez7 February 14, 2024 10:15
@portuu3 portuu3 self-assigned this Feb 14, 2024
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 4:04pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 4:04pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 4:04pm
job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 4:04pm
reputation-oracle-server ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 4:04pm

@portuu3 portuu3 added the WIP Work In Progress label Feb 14, 2024
@portuu3 portuu3 merged commit da63e8c into develop Feb 14, 2024
16 checks passed
@portuu3 portuu3 deleted the fix/jl-issues branch February 14, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants