-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Job Launcher] Split cron jobs to launch and lock while running. #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
portuu3
reviewed
Dec 22, 2023
packages/apps/job-launcher/server/src/common/interfaces/cron-job.ts
Outdated
Show resolved
Hide resolved
portuu3
reviewed
Dec 22, 2023
portuu3
reviewed
Dec 22, 2023
packages/apps/job-launcher/server/src/modules/job/job.service.ts
Outdated
Show resolved
Hide resolved
portuu3
reviewed
Dec 22, 2023
packages/apps/job-launcher/server/src/modules/job/job.service.ts
Outdated
Show resolved
Hide resolved
portuu3
reviewed
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also webhook cron job in webhook.service.ts should be included
I think these should be right statuses:
So for each cron job:
|
portuu3
requested changes
Jan 5, 2024
packages/apps/job-launcher/server/src/modules/cron-job/cron-job.service.ts
Show resolved
Hide resolved
portuu3
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to split the cron job to launch the escrow, to make every step more obvious - creation, setting up, and funding.
In addition, we'll handle all of those job entities with relevant status in each cron job run, and we want to lock cron job to prevent cron jobs running before previous one is finished.
Summary of changes
How test the changes
Related issues
Keywords for linking issues
Closes #1282, #1365.