-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Job Launcher] Launch hСaptcha jobs #1220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
13 Ignored Deployments
|
11 tasks
public async listObjectsInBucket(bucketUrl: string): Promise<string[]> { | ||
return new Promise(async (resolve, reject) => { | ||
try { | ||
const response = await axios.get(bucketUrl); |
Check failure
Code scanning / CodeQL
Server-side request forgery
The [URL](1) of this request depends on a [user-provided value](2).
The [URL](1) of this request depends on a [user-provided value](3).
The [URL](1) of this request depends on a [user-provided value](4).
portuu3
requested changes
Nov 8, 2023
packages/apps/job-launcher/server/src/common/constants/index.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/job/job.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/job-launcher/server/src/modules/storage/storage.service.ts
Outdated
Show resolved
Hide resolved
portuu3
reviewed
Dec 6, 2023
Co-authored-by: portuu3 <[email protected]>
portuu3
previously approved these changes
Dec 19, 2023
portuu3
previously approved these changes
Dec 19, 2023
portuu3
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a new job type called hCaptcha within Job Launcher to allow the launching of jobs with specific types, such as
ImageLabelBinary
,ImageLabelMultipleChoice
,ImageLabelAreaSelect
, andTextFreeEntry
. The goal is to create an infrastructure that will allow new jobs of this type to be created in the job service. The infrastructure includes creating new classes that use theclass-validator
as part of manifest validation process, adding a manifest encryption before sending it to the public bucket, adding data file generation for using hCaptcha.Summary of changes
POST /job/hCaptcha
controllercreateJob
method in Job ServicecreateHCaptchaManifest
method in Job ServiceHow test the changes
POST /job/hCaptcha
with bodyPOST /job/cron/launch
yarn test
Use the deployed version of the job launcher server to launch hCaptcha jobs.
Related issues
Job Launcher - Launch hСaptcha jobs#993