Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Job Launcher] Parse url #1182

Merged
merged 7 commits into from
Nov 2, 2023
Merged

[Job Launcher] Parse url #1182

merged 7 commits into from
Nov 2, 2023

Conversation

eugenvoronov
Copy link
Contributor

Description

Added new regular expressions to the URL parser. The URL parser must be able to work with the link type provided by AWS.

Summary of changes

  • Added new regex.
  • Added error handling

How test the changes

Send POST http://127.0.0.1:5001/job/cvat
with dataUrl param https://cvat-test-dataset.s3.eu-west-1.amazonaws.com or https://s3.eu-west-1.amazonaws.com/cvat-test-dataset

Related issues

[Job Launcher] Add AWS regex to url parser#1176

@eugenvoronov eugenvoronov requested a review from Dzeranov November 2, 2023 08:58
@eugenvoronov eugenvoronov self-assigned this Nov 2, 2023
@eugenvoronov eugenvoronov linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fortune-recording-oracle ❌ Failed (Inspect) Nov 2, 2023 9:35am
job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 9:35am
11 Ignored Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
fortune-exchange-oracle ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
fortune-exchange-oracle-server ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
fortune-job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
fortune-job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
fortune-reputation-oracle ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
hufi-exchange-oracle-server ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
hufi-job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am
reputation-oracle-server ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 9:35am

Copy link
Contributor

@Dzeranov Dzeranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log()

Dzeranov
Dzeranov previously approved these changes Nov 2, 2023
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle November 2, 2023 09:35 Inactive
@Dzeranov Dzeranov merged commit 2bc5ca1 into develop Nov 2, 2023
@leric7 leric7 deleted the fix/launcher/parse-url branch November 3, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Job Launcher] Add AWS regex to url parser
2 participants