Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Reputation Oracle] Update processing pending/paid escrow #1129

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

leric7
Copy link
Collaborator

@leric7 leric7 commented Oct 25, 2023

Description

We only need to set the escrow status to paid if the escrow balance is 0.
And we need to complete the escrow while processing paid escrows.

Summary of changes

  • Only update webhook entity to paid, when the balance is 0.
  • Complete the escrow when processing paid webhook entity.

How test the changes

Related issues

Keywords for linking issues

Closes #1090

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
escrow-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
fortune-exchange-oracle ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
fortune-exchange-oracle-server ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
fortune-job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
fortune-job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
fortune-recording-oracle ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
fortune-reputation-oracle ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
job-launcher-client ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm
job-launcher-server ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 4:16pm

@leric7 leric7 self-assigned this Oct 25, 2023
@leric7 leric7 linked an issue Oct 25, 2023 that may be closed by this pull request
Copy link
Contributor

@flopez7 flopez7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

@leric7 leric7 requested a review from flopez7 October 25, 2023 16:16
@flopez7 flopez7 merged commit 22553ce into develop Oct 26, 2023
@flopez7 flopez7 deleted the eric/reputation-oracle-complete-escrow branch October 26, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reputation Oracle - Set the escrow to completed if balance = 0
2 participants